Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct access-control-allow-methods cors header name #944

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#19057

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This corrects the CORS header name we were applying

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 15, 2023
@danielroe danielroe self-assigned this Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #944 (8584ca5) into main (90cf636) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files          59       59           
  Lines        6010     6010           
  Branches      676      676           
=======================================
  Hits         4073     4073           
  Misses       1928     1928           
  Partials        9        9           
Impacted Files Coverage Ξ”
src/options.ts 86.76% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: correct cors header name fix: correct access-control-allow-methods cors header name Feb 15, 2023
@pi0 pi0 merged commit 84da375 into main Feb 15, 2023
@pi0 pi0 deleted the fix/cors-header branch February 15, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong CORS header access-control-allowed-methods should be access-control-allow-methods
2 participants